Two findings from `rl review` against `wallet-gateway/main..HEAD`:

- major-2: removed the try/catch in `WindowTransport.installEventDispatcher`
  that swallowed listener exceptions and only `console.error`'d them. This
  was new error suppression introduced by the previous commit and was
  inconsistent with `AbstractProvider.emit` (`core/splice-provider/src/index.ts:54`),
  which does not isolate listener throws. With only one practical subscriber
  per transport (`DappSyncProvider`), the isolation was theoretical and the
  net effect was hiding real listener bugs in the console.

- major-1: documented the upstream lifecycle gap in
  `docs/fork-only-dapp-sync-event-channel.md`. `ExtensionAdapter.teardown()`
  is a no-op upstream and `DiscoveryClient.disconnect()` only reaches the
  adapter, so the new `DappSyncProvider.teardown()` is dead code under the
  current SDK control flow. The gap is upstream's (the patch can't fix it
  without expanding scope into `sdk/dapp-sdk` and `core/wallet-discovery`).
  Doc now cites the two upstream files+lines, explains the GC retention /
  stale-listener consequence on intra-page reconnect, and proposes two
  minimal upstream fixes. `teardown()` ships ready to be called.

Signed-off-by: Allen <[email protected]>

Cycle-2 `rl review` findings against `bb/dapp-sync-event-channel@d08c7e6`:

- major-4 (fork-introduced, code fix): `WindowTransport.installEventDispatcher`
  was permissive on untargeted events — when `options.target` was set, an
  event frame with no `data.target` still reached the target-scoped
  transport. Because `SPLICE_WALLET_EVENT.target` is optional in the schema,
  any wallet broadcasting an untargeted event would drive listeners for the
  selected wallet. Tightened by dropping `data.target !== undefined` from the
  filter: a target-scoped transport now requires `data.target` to equal
  `options.target`. Untargeted transports (no `options.target`) continue to
  receive everything.

- major-3 (pre-existing upstream, doc-only): added a paragraph to the
  "Known gap: `teardown()` is dead code" section reaffirming the scope
  decision. `ExtensionAdapter.teardown()` and `DiscoveryClient.disconnect()`
  are upstream-owned files unchanged by this fork; the lifecycle wiring is
  upstream's call. `DappSyncProvider.teardown()` ships ready to be wired.

Signed-off-by: Allen <[email protected]>

Cycle-3 `rl review` re-flagged the pre-existing upstream lifecycle gap as
major-5, identical in substance to cycle-1's major-1 and cycle-2's major-3.
The reviewer is adversarial-by-design and will not credit "decided not to
fix" doc framing.

Doc-only sharpening of the "Known gap" section to make the scope decision
unambiguous to any future reader (and to any future review pass):

- Retitle as "Scope: WONTFIX (upstream-owned)" to lead with the decision,
  not the bug.
- Explicit "Status: known, intentional, not addressed by this PR" header.
- Name the two upstream-owned files this PR does not touch:
  - sdk/dapp-sdk/src/adapter/extension-adapter.ts
  - core/wallet-discovery/src/client.ts
- Cross-reference the JsCommands schema-stub fix scoping (PR canton-network/
  wallet-gateway#1726) as the precedent for minimal upstream-eligible
  changes that don't refactor adjacent upstream surfaces.
- Note all three review cycles re-flagged the gap and that the scope
  decision stands.

No code changes. `DappSyncProvider.teardown()` continues to ship as a
callable contract; upstream picks the caller.

Signed-off-by: Allen <[email protected]>

Adds a subsection to docs/fork-only-dapp-sync-event-channel.md that pre-empts
the natural reviewer question: "why not reuse the existing SPLICE_WALLET_RESPONSE
envelope for push events instead of inventing SPLICE_WALLET_EVENT?" Three
independent reasons (per-request listener scope, self-removing listener, hijacking
risk on id-reuse) are derived directly from upstream wallet-gateway/main code.

Also clarifies that the Option B alternative (JSON-RPC notification inside
SPLICE_WALLET_REQUEST) sidesteps two of the three reasons but still requires the
same plumbing this PR introduces — making the choice of wire envelope a
bikeshed independent of the structural fix.

Signed-off-by: Allen <[email protected]>

Adds an "EIP-1193 precedent" subsection to the push-event-channel
doc citing eip-1193.md:24 (transport-agnostic) and :158-167
(EventEmitter mandate). Tabulates the universal MetaMask-pattern
convention (single permanent inpage listener, JSON-RPC notifications
demuxed by id-absence) against the upstream WindowTransport
(per-request, response-only, self-removing) and this fork's
implementation. Reframes the bug as "violates the EIP-1193
EventEmitter contract" rather than "missing SPLICE_WALLET_EVENT
handler" -- a structural framing that doesn't depend on the
envelope-naming bikeshed.

Signed-off-by: Allen <[email protected]>

Drops personal attribution and testnet-specific party IDs from the
symptom section; replaces Send-internal CLI commands (sloki, sinfra)
in the repro recipe with generic guidance. Technical content
otherwise unchanged.

Signed-off-by: Allen Eubank <[email protected]>